Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various fixes for defunctionalization & brillig gen #1973

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jul 19, 2023

Description

Problem*

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

ludamad
ludamad previously approved these changes Jul 19, 2023
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff with defunctionalize seem that they could use a pass to read less like the raw data structure manipulation operations or raw SSA traversal for function values, but I rather merge fast and let you ponder that longer

LGTM

ludamad
ludamad previously approved these changes Jul 19, 2023
@jfecher
Copy link
Contributor

jfecher commented Jul 19, 2023

Also, can we split this up into smaller PRs next time (ideally one per issue)? Many of these changes seem unrelated and this PR solving several issues makes each individual fix more difficult to isolate. It's also easier reviewing several smaller PRs than one larger one, especially if part of the larger PR becomes blocking for the rest of it.

@jfecher jfecher enabled auto-merge July 19, 2023 20:06
@jfecher jfecher added this pull request to the merge queue Jul 19, 2023
Merged via the queue into master with commit f99f4bf Jul 19, 2023
@jfecher jfecher deleted the arv/various_fixes branch July 19, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants