Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial implementation of slices in brillig #1932

Merged
merged 9 commits into from
Jul 17, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jul 14, 2023

Description

Problem*

Resolves using slices in unconstrained functions.

It still doesn't support passing the slice to a function and storing slices in mutable variables due to an issue with SSA typing detailed in #1931

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant marked this pull request as ready for review July 14, 2023 17:16
@kevaundray kevaundray added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit ea47936 Jul 17, 2023
@kevaundray kevaundray deleted the arv/slices_in_brillig branch July 17, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants