-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(brillig_gen): Return slices from foreign calls #1909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Jul 11, 2023
crates/nargo_cli/tests/test_data_ssa_refactor/brillig_oracle/src/main.nr
Outdated
Show resolved
Hide resolved
crates/nargo_cli/tests/test_data_ssa_refactor/brillig_oracle/src/main.nr
Outdated
Show resolved
Hide resolved
Co-authored-by: jfecher <[email protected]>
Co-authored-by: jfecher <[email protected]>
Co-authored-by: jfecher <[email protected]>
jfecher
previously approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you create an issue for the two remaining comments? Then we can merge this
jfecher
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Partial works towards #1556
Summary*
Now that slices are implemented on the frontend and in the SSA refactor we need to enable code gen for both Brillig and ACIR. This some partial work towards the Brillig gen for slices that enables us to return a slice from an external call like below:
I have also included a test that makes two different foreign calls to verify that memory has not been overwritten and we can iterate over the dynamic slices returned from the foreign call inside Brillig.
Other work is being done in parallel to enable these dynamic slices to be returned from Brillig into ACIR and handled inside of ACIR.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.