Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement references in brillig #1901

Merged
merged 2 commits into from
Jul 10, 2023
Merged

feat: Implement references in brillig #1901

merged 2 commits into from
Jul 10, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jul 10, 2023 •
edited
Loading

Description

Problem*

Summary*

  • Implemented reference handling in brillig
  • Fixing a bug where the registers were not correctly restored if the callee function did memory allocs (lack of prev stack pointer register)
  • Avoided freeing memory by never reducing the stack pointer, to implement references without borrow checker / garbage collector

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

ludamad
ludamad approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sirasistant sirasistant added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit 3a078fb Jul 10, 2023
@sirasistant sirasistant deleted the arv/brillig_refs branch July 10, 2023 12:40
@kevaundray kevaundray mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@ludamad ludamad ludamad approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @ludamad @jfecher