fix(ssa refactor): Speedup acir-gen #1793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #1750
Summary*
After a flamegraph profiling I found out that most time in acir-gen for the
eddsa
test was spent inmul_var
andsub_var
, and most time in those methods was spent inTwoWayMap::insert
where to insert a new AcirVar, AcirVarData pair we were callingFieldElement::eq
repeatedly which usesto_bytes_be
internally.To fix this, I changed the
TwoWayMap
to a single-way map. The downside of this fix is if an identicalAcirVarData
is ever tried to be inserted, it will be assigned a new id instead of an existing one. This may slow down proving later on.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.