Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): ACIR gen NOT integer #1749

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix(ssa refactor): ACIR gen NOT integer #1749

merged 2 commits into from
Jun 20, 2023

Conversation

joss-aztec
Copy link
Contributor

Description

Problem*

ACIR gen assumed NOT to only handle bools.

Resolves GH-1748

Summary*

Add NOT integer support

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@joss-aztec
Copy link
Contributor Author

This PR in conjunction with #1747 fixes the test named 8_integration.

@joss-aztec joss-aztec mentioned this pull request Jun 19, 2023
Merged
5 tasks
kevaundray
kevaundray approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lets create an issue for proper signed integer support

@kevaundray kevaundray added this pull request to the merge queue Jun 20, 2023
@joss-aztec
Copy link
Contributor Author

Issue: #1763

Merged via the queue into master with commit af749a0 Jun 20, 2023
@kevaundray kevaundray deleted the joss/fix-1748 branch June 20, 2023 16:47
This was referenced Jun 20, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

! incorrectly ACIR gen'd
2 participants
@joss-aztec @kevaundray