Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): more comprehensive instruction simplification #1735

Merged
merged 6 commits into from
Jun 16, 2023
Merged

fix(ssa refactor): more comprehensive instruction simplification #1735

merged 6 commits into from
Jun 16, 2023

Conversation

joss-aztec
Copy link
Contributor

Description

Problem*

Resolves GH-1713

Summary*

  • Compute radix decomposition of constants at compile time
  • Simplify cast to Field of a constant to redeclaring the constant with Field type

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

jfecher
jfecher reviewed Jun 16, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the additional simplification calls, do you think the problem in example 6 was not that it was looping forever but that there was so much IR generated that acir-gen or some other step took an unreasonable amount of time to finish?

@joss-aztec
Copy link
Contributor Author

Yep, I do think so.

jfecher
jfecher requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some style suggestions

crates/noirc_evaluator/src/ssa_refactor/ir/instruction.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa_refactor/ir/instruction.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa_refactor/ir/instruction.rs Outdated Show resolved Hide resolved
jfecher
jfecher approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfecher jfecher enabled auto-merge June 16, 2023 17:44
@jfecher jfecher mentioned this pull request Jun 16, 2023
Merged
5 tasks
@jfecher jfecher added this pull request to the merge queue Jun 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 16, 2023
@jfecher jfecher added this pull request to the merge queue Jun 16, 2023
Merged via the queue into master with commit 97d6747 Jun 16, 2023
@jfecher jfecher deleted the joss/fix-1713 branch June 16, 2023 21:37
This was referenced Jun 16, 2023
Closed
Merged
@joss-aztec joss-aztec mentioned this pull request Jun 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test name 6 hangs
2 participants
@joss-aztec @jfecher