Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): BigUint for radix #1715

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix(ssa refactor): BigUint for radix #1715

merged 1 commit into from
Jun 16, 2023

Conversation

joss-aztec
Copy link
Contributor

@joss-aztec joss-aztec commented Jun 15, 2023 •
edited
Loading

Description

Problem*

Resolves GH-1697

Summary*

Prevent u32 overflow in radix calculation

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher
Copy link
Contributor

jfecher commented Jun 15, 2023

Resolves #1687

Do we not need to implement Intrinsic::Sort?

@joss-aztec
Copy link
Contributor Author

Gah, typo, should have been 1697

@jfecher jfecher enabled auto-merge June 15, 2023 16:43
@jfecher jfecher added this pull request to the merge queue Jun 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 15, 2023
@kevaundray kevaundray added this pull request to the merge queue Jun 15, 2023
Merged via the queue into master with commit 00cf462 Jun 16, 2023
@kevaundray kevaundray deleted the joss/fix-1687 branch June 16, 2023 00:16
This was referenced Jun 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attempt to multiply with overflow
3 participants
@joss-aztec @jfecher @kevaundray