Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location information to AcirGenError::IndexOutOfBounds #1412

Closed
Tracked by #1376
jfecher opened this issue May 26, 2023 · 2 comments
Closed
Tracked by #1376

Add location information to AcirGenError::IndexOutOfBounds #1412

jfecher opened this issue May 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request refactor ssa

Comments

@jfecher
Copy link
Contributor

jfecher commented May 26, 2023

Problem

If the acir-gen pass for the new SSA IR encounters an index out of bounds error, the offending index will be reported, but users will have no indication where in their code this actually occurred.

Happy Case

Ideally, we add Locations to this error so that when it is issued users will be able to see a clear error message and can find and fix the issue faster.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray
Copy link
Contributor

@guipublic what is the status of this issue?

@vezenovm
Copy link
Contributor

This was resolved here (#2389) so closing this issue

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor ssa
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants