Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve globals in types #1043

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: Resolve globals in types #1043

merged 1 commit into from
Mar 28, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Mar 27, 2023

Related issue(s)

Resolves #1042

Description

Summary of changes

Previously we checked for global constants when resolving array sizes in types but not when resolving arbitrary types. This lead to issues when trying to pass globals as a struct's numeric generics. I've factored out the common code to check for this in both places to resolve the issue.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@jfecher jfecher changed the title Fix resolving globals in types fix: Resolve globals in types Mar 27, 2023
@kevaundray kevaundray added this pull request to the merge queue Mar 28, 2023
Merged via the queue into master with commit 2badf14 Mar 28, 2023
@kevaundray kevaundray deleted the jf/fix-globals-in-types branch March 28, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use globals in struct generics
2 participants