Skip to content

Commit

Permalink
update TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
phated authored Jun 13, 2023
1 parent 723439a commit c212ac0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions crates/lsp/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ fn on_did_save_text_document(
state: &mut LspState,
params: DidSaveTextDocumentParams,
) -> ControlFlow<Result<(), async_lsp::Error>> {
// TODO: Requiring `Language` and `is_opcode_supported` to construct a driver makes for some real stinky code
// TODO(#1680): Remove driver requirement of `Language` and `is_opcode_supported`
// The driver should not require knowledge of the backend; instead should be implemented as an independent pass (in nargo?)
let mut driver = Driver::new(&Language::R1CS, Box::new(|_op| false));

Expand All @@ -176,7 +176,7 @@ fn on_did_save_text_document(
let files = fm.as_simple_files();

for FileDiagnostic { file_id, diagnostic } in file_diagnostics {
// TODO: This file_id never be 0 because the "path" where it maps is the directory, not a file
// TODO(#1681): This file_id never be 0 because the "path" where it maps is the directory, not a file
if file_id.as_usize() != 0 {
continue;
}
Expand All @@ -185,7 +185,7 @@ fn on_did_save_text_document(

// TODO: Should this be the first item in secondaries? Should we bail when we find a range?
for sec in diagnostic.secondaries {
// TODO: Codespan ranges are often (always?) off by some amount of characters
// TODO(#1683): Codespan ranges are often (always?) off by some amount of characters
if let Ok(codespan_range) =
codespan_lsp::byte_span_to_range(files, file_id.as_usize(), sec.span.into())
{
Expand Down

0 comments on commit c212ac0

Please sign in to comment.