Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example benchmark workflow #7

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Nov 15, 2024

Description

Problem*

Resolves

Summary*

This PR adds an example workflow to show how to add benchmarking into a Noir library.

This is definitely not perfect for a few reasons some known (e.g. benchmarks with the same name in different modules will silently override one another) and likely some unknown but is better than the alternative and we can iterate on it.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench force-pushed the tf/add-example-benchmark branch 5 times, most recently from 6b463cd to 3c6a357 Compare November 15, 2024 12:52
@TomAFrench TomAFrench merged commit d461e2e into master Nov 15, 2024
7 checks passed
@TomAFrench TomAFrench deleted the tf/add-example-benchmark branch November 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant