Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix: Switch nix build to use github protocol to fetch any commit #30

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jun 20, 2023

Description

Problem*

Resolves #29

Summary*

This switches the way bb is fetched by nix build so we can fetch any commit on bb.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

kobyhallx
kobyhallx previously approved these changes Jun 20, 2023
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

TomAFrench
TomAFrench previously approved these changes Jun 20, 2023
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's made it passed the place it was erroring out before.

@phated phated dismissed stale reviews from TomAFrench and kobyhallx via a74c7bc June 21, 2023 21:17
kobyhallx
kobyhallx previously approved these changes Jun 22, 2023
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phated phated merged commit 10ec799 into master Jun 22, 2023
@phated phated deleted the phated/nix-github-protocol branch June 22, 2023 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nightly build failed
3 participants