This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
fix: return false rather than panicking on invalid ECDSA signatures
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
false rather than panicking on invalid ECDSA signatures
TomAFrench
force-pushed
the
tf/handle-invalid-ecdsa-sigs
branch
from
043451f
to
8e99368
Compare
Merged
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves noir-lang/noir#2755
Summary*
This PR updates the ECDSA verification functions to return false rather than panicking on some failure modes. In particular, we now allow for zero values for
(r, s)and public keys which don't lie on the correct curve.Additional Context
PR Checklist*
cargo fmton default settings.