Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acir)!: automatically dedupe PublicInputs using a BTreeSet #99

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Related to noir-lang/noir#851 (comment)

Description

Summary of changes

This PR swaps out the implementation of PublicInputs to use a BTreeSet for native deduplication of public inputs mapped to the same witness index.

This should only create a breaking change up in noirc_evaluator where we're planning on switching this out for a BTreeSet anyway so this will avoid us having to convert to a Vec before creating the Circuit up there.

We can

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@TomAFrench TomAFrench changed the title feat(acir)!: make PublicInputs use a BTreeSet rather than Vec feat(acir)!: automatically dedupe PublicInputs using a BTreeSet Feb 16, 2023
@kevaundray kevaundray merged commit 53666b7 into master Feb 17, 2023
@github-actions github-actions bot mentioned this pull request Feb 17, 2023
@TomAFrench TomAFrench deleted the public-inputs-set branch February 17, 2023 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants