This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acir)!: automatically dedupe PublicInputs
using a BTreeSet
#99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Related to noir-lang/noir#851 (comment)
Description
Summary of changes
This PR swaps out the implementation of
PublicInputs
to use aBTreeSet
for native deduplication of public inputs mapped to the same witness index.This should only create a breaking change up in
noirc_evaluator
where we're planning on switching this out for aBTreeSet
anyway so this will avoid us having to convert to aVec
before creating theCircuit
up there.We can
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)