This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat: set Brillig VM state to Failure rather than panicking on invalid foreign call response
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid foreign call response
TomAFrench
changed the title
Failure rather than panicking on invalid foreign call responseFailure rather than panicking on invalid foreign call response
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Returning an incorrectly sized foreign call response to the Brillig VM will currently cause a panic. This is an issue for situations where the Brillig VM is running inside wasm as this doesn't handle panics well. As this is a case of a user providing invalid input, we should return an error rather than panicking.
Resolves #370 (comment)
Summary*
We now set the
VMStatustoFailurein this situation. I've had to delay this until after thefor-loopdue to the borrow-checker so I'd be open to any other solutions which avoid the need for the mutable bool + break.Additional Context
PR Checklist*
cargo fmton default settings.BEGIN_COMMIT_OVERRIDE
feat(brillig): Set
VMStatustoFailurerather than panicking on invalid foreign call response (#375)END_COMMIT_OVERRIDE