This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(brillig): Allow dynamic-size foreign calls #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
changed the title
kevaundray
reviewed
Jun 13, 2023
|
Very weird thing - when I closed my unconventionally-titled PR (had a DONT MERGE at start), this one started to report that failure |
vezenovm
reviewed
Jun 14, 2023
|
Mostly nit comments but this looks solid |
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
|
@vezenovm I merged your work into here, this could use another pass |
TomAFrench
reviewed
Jun 14, 2023
Merged
2 tasks
TomAFrench
changed the title
auto-merge was automatically disabled
June 14, 2023 14:43
Pull request was closed
Merged
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Incremental progress towards noir-lang/noir#1556
Takes this milestone "Add support for slices such that in Brillig we can call an oracle and have it return a slice with length not known and enumerate over that slice" and does the part necessary for such oracles in brillig vm
As an intro, start with the comment in brillig_vm/src/opcodes.rs
Additional Context
PR Checklist*
cargo fmton default settings.