Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

fix(brillig): Explicitly wrap on arithmetic operations #365

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

sirasistant
Copy link
Contributor

Description

Problem*

Resolves #360

Summary*

This PR sets out to

Example

Before:


After:


Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant requested a review from ludamad June 12, 2023 12:41
@TomAFrench TomAFrench changed the title fix(brillig): explicitely wrap on arithmetic operations fix(brillig): Explicitly wrap on arithmetic operations Jun 12, 2023
Copy link
Contributor

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludamad
Copy link
Contributor

ludamad commented Jun 12, 2023

I'll let @kevaundray look but in the future should I just merge these if I'm confident? Or would you like final say?

@kevaundray
Copy link
Contributor

I'll let @kevaundray look but in the future should I just merge these if I'm confident? Or would you like final say?

Yeah its fine to merge these Brillig based PRs tentatively

@kevaundray kevaundray added this pull request to the merge queue Jun 13, 2023
Merged via the queue into master with commit c0544a9 Jun 13, 2023
@kevaundray kevaundray mentioned this pull request Jun 13, 2023
sirasistant added a commit that referenced this pull request Jun 13, 2023
@TomAFrench TomAFrench deleted the arv/wrapping_ops_rebased branch June 14, 2023 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly define behaviour on overflow/underflow in Brillig operations
3 participants