Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Add cargo smart-release #19

Closed
kevaundray opened this issue Dec 23, 2022 · 5 comments
Closed

Add cargo smart-release #19

kevaundray opened this issue Dec 23, 2022 · 5 comments

Comments

@kevaundray
Copy link
Contributor

No description provided.

@phated
Copy link
Contributor

phated commented Jan 31, 2023

cargo-smart-release seems great! And it even mentions they use the same Conventional Commits spec as I suggested in Noir. I think the reason I'd lean towards release-please is the ability to share workflows across various projects that may be rust, typescript, etc.

What do you think?

@kevaundray
Copy link
Contributor Author

Yeah I think a homogenous approach would be better.

My only point towards cargo-smart-release was the fact that it seems to recognise workspaces, but we can get the same functionality that I would like by doing feat(acvm), feat(acir), feat({workspace_name})`

@kevaundray
Copy link
Contributor Author

(Keeping this issue open until we switch to release-please)

@phated
Copy link
Contributor

phated commented Jan 31, 2023

Oh yeah, release-please has cargo-workspace support but you have to move away from specifying the version in the workspace file so it can manage the crates independently, which I felt was too heavy-handed/overkill for the noir repo but maybe it makes sense to diverge for this repo.

@kevaundray
Copy link
Contributor Author

Closing this as we are using release-please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants