This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm): add eth_contract_from_vk to `SmartContract
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: deprecate `eth_contract_from_cs`
|
Adding a deprecation shouldn't be breaking. It's just a warning that something will have a breaking change in the future. |
vezenovm
approved these changes
Feb 22, 2023
Whoops, got a bit trigger happy with all the breaking changes recently 😅 |
TomAFrench
changed the title
eth_contract_from_vk to `SmartContracteth_contract_from_vk to `SmartContract
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: deprecate
eth_contract_from_csRelated issue(s)
Resolves #102
Description
Summary of changes
eth_contract_from_csis now deprecated andeth_contract_from_vkhas been added which takes a&[u8]rather than aCircuit.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)