Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why can we just have the generator output D directly instead of outputting L and reconstructing D? #3

Open
lkqnaruto opened this issue Nov 11, 2022 · 1 comment

Comments

@lkqnaruto
Copy link

lkqnaruto commented Nov 11, 2022

Hi

Thank you for releasing the code and I really appreciate the hard work.

I wonder in Algorithm 1, Why can we just have the generator output D directly instead of outputting L and reconstructing D?

For example:

$\hat{D} = G(z)$
Symmetrize $\hat{D}$
Then Compute eigenvalues of $\frac{1}{2}J\hat{D}J $

@clonker
Copy link
Member

clonker commented Nov 11, 2022

1st of all wow, I had no idea you could embed maths into github markdown now, that's cool!

The rationale was that distance matrices form a cone so generating it directly would be quite difficult regarding sgd. Although I am not 100% on this anymore, it is just what worked at the time. I feel like you can probably do a lot better by your approach or a manifold-aware optimization which takes the cone curvature into account.
Do you have thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants