feat: run "stop" when startup throws a error

typegoose · Jan 15, 2022 · 235a09f · 235a09f
1 parent ca38110
commit 235a09f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts b/packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts
@@ -353,11 +353,13 @@ export class MongoMemoryReplSet extends EventEmitter implements ManagerAdvanced
     await ensureAsync()
       .then(() => this.initAllServers())
       .then(() => this._initReplSet())
-      .catch((err) => {
+      .catch(async (err) => {
         if (!debug.enabled('MongoMS:MongoMemoryReplSet')) {
           console.warn('Starting the ReplSet failed, enable debug for more information');
         }
 
+        await this.stop(false); // still try to close the instance that was spawned, without cleanup for investigation
+
         this.stateChange(MongoMemoryReplSetStates.stopped);
 
         throw err;

diff --git a/packages/mongodb-memory-server-core/src/MongoMemoryServer.ts b/packages/mongodb-memory-server-core/src/MongoMemoryServer.ts
@@ -276,11 +276,13 @@ export class MongoMemoryServer extends EventEmitter implements ManagerAdvanced {
 
     this.stateChange(MongoMemoryServerStates.starting);
 
-    await this._startUpInstance(forceSamePort).catch((err) => {
+    await this._startUpInstance(forceSamePort).catch(async (err) => {
       if (!debug.enabled('MongoMS:MongoMemoryServer')) {
         console.warn('Starting the instance failed, enable debug for more information');
       }
 
+      await this.stop(false); // still try to close the instance that was spawned, without cleanup for investigation
+
       this.stateChange(MongoMemoryServerStates.stopped);
 
       throw err;