Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aggs.ts - don't convert strings to objects #146

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

amran99
Copy link
Contributor

@amran99 amran99 commented Sep 30, 2022

This PR fixes the following issue:
#145

Expected:
{ terms: { field: 'source.keyword', exclude: ['Other', 'unknown'] } }

Actual:
{ terms: { field: 'source.keyword', exclude: [{0: 'O', 1: 't', 2: 'h', 3: 'e', 4: 'r'}, {0: 'u', 1: 'n', 2: 'k', 3: 'n', 4: 'o', 5: 'w', 6: 'n'}] } }

This fix will ensure strings are not converted to objects

@codecov-commenter
Copy link

Codecov Report

Base: 80.41% // Head: 80.42% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (27c2a3d) compared to base (8e52919).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   80.41%   80.42%   +0.01%     
==========================================
  Files         108      108              
  Lines        1818     1819       +1     
  Branches      290      291       +1     
==========================================
+ Hits         1462     1463       +1     
  Misses        356      356              
Impacted Files Coverage Δ
src/elasticDSL/Aggs/Aggs.ts 92.59% <100.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nodkz nodkz merged commit bf32358 into graphql-compose:master Sep 30, 2022
@nodkz
Copy link
Member

nodkz commented Sep 30, 2022

Thanks a lot 🙏

@github-actions
Copy link

🎉 This PR is included in version 5.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants