Search in the docs broken

[marcelstoer]

Due to readthedocs/readthedocs.org#1088 the search in our docs on RTD has been broken from the beginning. Yesterday I finally implemented an ugly work-around for dev: 7dd89dd.

If you now go to http://nodemcu.readthedocs.io/en/dev/ and search for 'gyroscope' you'll get a more or less expected result. If you do the same on http://nodemcu.readthedocs.io/en/master/ it'll fail.

Fellow committers, do you think this fix is important enough to be merged back to master right away i.e. before the next snap in seven weeks?

[devsaurus]

This is an inconvenience for the user IMO. But neither wrong nor outdated Information which would break user code.
Thus I'd consider it as not critical & not urgent. Nonethless, thanks a lot for spotting and fixing it. This web coding is a miracle to me 😉

[marcelstoer]

Thus I'd consider it as not critical & not urgent.

I agree but wanted to verify my assessment with the group.

[marcelstoer]

I interpret silence as agreement with Armin (and myself) -> closing.