-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make dispatcher truly global #1405
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1405 +/- ##
=======================================
Coverage 94.28% 94.29%
=======================================
Files 47 48 +1
Lines 4250 4256 +6
=======================================
+ Hits 4007 4013 +6
Misses 243 243
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I still think it would be useful to encode in the global dispatcher the version, even if we are not using it right now.
In this case if in the future there is the need to do a breaking change, we already have the code to handle it.
@delvedor done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Make the dispatcher truly global * make sure the global dispatcher is used for Node.js fetch * Fix test * added version number
@delvedor uses a pool, so it's bypassing this system. I'd recommend the ES client to accept an undici dispatcher as an option. |
* Make the dispatcher truly global * make sure the global dispatcher is used for Node.js fetch * Fix test * added version number
* Make the dispatcher truly global * make sure the global dispatcher is used for Node.js fetch * Fix test * added version number
Fixes #1331