Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore wasm file for npm publishing #1219

Merged
merged 1 commit into from
Feb 10, 2022
Merged

chore: ignore wasm file for npm publishing #1219

merged 1 commit into from
Feb 10, 2022

Conversation

Kikobeats
Copy link
Contributor

After #1183, WASM files are no more necessary to be shipped as part of the NPM bundle

@mcollina
Copy link
Member

I thiink we need to add a bit more things from .gitignore, have you tried looking inside the generated package?

@Kikobeats
Copy link
Contributor Author

@mcollina I think the rest of things are ok. This is how it looks like right now:

.
├── LICENSE
├── README.md
├── docs
│   ├── api
│   │   ├── Agent.md
│   │   ├── BalancedPool.md
│   │   ├── Client.md
│   │   ├── Connector.md
│   │   ├── DiagnosticsChannel.md
│   │   ├── Dispatcher.md
│   │   ├── Errors.md
│   │   ├── MockAgent.md
│   │   ├── MockClient.md
│   │   ├── MockErrors.md
│   │   ├── MockPool.md
│   │   ├── Pool.md
│   │   ├── ProxyAgent.md
│   │   └── api-lifecycle.md
│   ├── assets
│   │   └── lifecycle-diagram.png
│   └── best-practices
│       ├── client-certificate.md
│       ├── mocking-request.md
│       ├── proxy.md
│       └── writing-tests.md
├── index.d.ts
├── index.js
├── lib
│   ├── agent.js
│   ├── api
│   │   ├── abort-signal.js
│   │   ├── api-connect.js
│   │   ├── api-pipeline.js
│   │   ├── api-request.js
│   │   ├── api-stream.js
│   │   ├── api-upgrade.js
│   │   ├── index.js
│   │   └── readable.js
│   ├── balanced-pool.js
│   ├── client.js
│   ├── compat
│   │   └── dispatcher-weakref.js
│   ├── core
│   │   ├── connect.js
│   │   ├── errors.js
│   │   ├── request.js
│   │   ├── symbols.js
│   │   └── util.js
│   ├── dispatcher.js
│   ├── fetch
│   │   ├── LICENSE
│   │   ├── body.js
│   │   ├── constants.js
│   │   ├── dataURL.js
│   │   ├── file.js
│   │   ├── formdata.js
│   │   ├── headers.js
│   │   ├── index.js
│   │   ├── request.js
│   │   ├── response.js
│   │   ├── symbols.js
│   │   └── util.js
│   ├── handler
│   │   └── redirect.js
│   ├── llhttp
│   │   ├── constants.d.ts
│   │   ├── constants.js
│   │   ├── constants.js.map
│   │   ├── llhttp.wasm
│   │   ├── llhttp.wasm.js
│   │   ├── llhttp_simd.wasm
│   │   ├── llhttp_simd.wasm.js
│   │   ├── utils.d.ts
│   │   ├── utils.js
│   │   └── utils.js.map
│   ├── mock
│   │   ├── mock-agent.js
│   │   ├── mock-client.js
│   │   ├── mock-errors.js
│   │   ├── mock-interceptor.js
│   │   ├── mock-pool.js
│   │   ├── mock-symbols.js
│   │   └── mock-utils.js
│   ├── node
│   │   └── fixed-queue.js
│   ├── pool-base.js
│   ├── pool.js
│   └── proxy-agent.js
├── package.json
└── types
    ├── agent.d.ts
    ├── api.d.ts
    ├── balanced-pool.d.ts
    ├── client.d.ts
    ├── connector.d.ts
    ├── dispatcher.d.ts
    ├── errors.d.ts
    ├── fetch.d.ts
    ├── file.d.ts
    ├── formdata.d.ts
    ├── global-dispatcher.d.ts
    ├── mock-agent.d.ts
    ├── mock-client.d.ts
    ├── mock-errors.d.ts
    ├── mock-interceptor.d.ts
    ├── mock-pool.d.ts
    ├── pool.d.ts
    └── proxy-agent.d.ts

14 directories, 94 files

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 221c6ae into nodejs:main Feb 10, 2022
@Kikobeats Kikobeats deleted the npmignore branch February 10, 2022 17:29
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants