ProxyAgent ignores connect timeout options and lacks documentation for signal parameter

[timursevimli]

Bug Description

The connect options passed to ProxyAgent are being ignored, despite the type definitions suggesting they should work. This appears to be both a potential bug and a documentation issue.

Reproducible By

const { ProxyAgent } = require('undici');

const agent = new ProxyAgent({
  uri: 'http://8.8.8.8:8000',
  connect: {
    signal: AbortSignal.timeout(100),
    timeout: 100,
  },
});

fetch('https://example.com', {
  dispatcher: agent,
})
  .then((res) => res.text())
  .then(console.log)
  .catch(console.error);

Current Behavior

The timeout and signal parameters in connect options are not being processed when passed to ProxyAgent

Expected Behavior

According to the documentation:

• ProxyAgentOptions extends AgentOptions
• AgentOptions extends PoolOptions
• PoolOptions extends ClientOptions
• ClientOptions includes connect parameter which accepts ConnectOptions

Therefore, the timeout and signal options should work when passed through the connect parameter.

Relevant Documentation Links

• ConnectOptions Documentation
• ClientOptions Documentation

[mcollina]

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

[timursevimli]

Yes, I will make a pull request