fix: PoolBase kClose and kDestroy should await and not return the Pro…

…mise (#3716) (#3723) (cherry picked from commit cda5f94) Co-authored-by: Aras Abbasi <[email protected]>
nodejs · Oct 12, 2024 · fd32a55 · fd32a55
1 parent a699105
commit fd32a55
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/dispatcher/pool-base.js b/lib/dispatcher/pool-base.js
@@ -113,9 +113,9 @@ class PoolBase extends DispatcherBase {
 
   async [kClose] () {
     if (this[kQueue].isEmpty()) {
-      return Promise.all(this[kClients].map(c => c.close()))
+      await Promise.all(this[kClients].map(c => c.close()))
     } else {
-      return new Promise((resolve) => {
+      await new Promise((resolve) => {
         this[kClosedResolve] = resolve
       })
     }
@@ -130,7 +130,7 @@ class PoolBase extends DispatcherBase {
       item.handler.onError(err)
     }
 
-    return Promise.all(this[kClients].map(c => c.destroy(err)))
+    await Promise.all(this[kClients].map(c => c.destroy(err)))
   }
 
   [kDispatch] (opts, handler) {