fix(H2 Client): bind stream 'data' listener only after received 'resp…

…onse' event (#2985) * fix(fetch): pause stream if data is received before headers in HTTP/2 * Revert "fix(fetch): pause stream if data is received before headers in HTTP/2" This reverts commit cd2eaf4. * fix(H2 Client): pause stream if response data is sent before response event * Revert "fix(H2 Client): pause stream if response data is sent before response event" This reverts commit 9219ee3. * fix(H2 Client): bind stream 'data' listener once 'response' is triggered ref: https://nodejs.org/api/http2.html#clienthttp2sessionrequestheaders-options --------- Co-authored-by: Stefano <[email protected]>
nodejs · Mar 25, 2024 · c9acca9 · c9acca9
1 parent 0ec5a40
commit c9acca9
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/dispatcher/client-h2.js b/lib/dispatcher/client-h2.js
@@ -394,6 +394,12 @@ function writeH2 (client, request) {
     if (request.onHeaders(Number(statusCode), realHeaders, stream.resume.bind(stream), '') === false) {
       stream.pause()
     }
+
+    stream.on('data', (chunk) => {
+      if (request.onData(chunk) === false) {
+        stream.pause()
+      }
+    })
   })
 
   stream.once('end', () => {
@@ -418,12 +424,6 @@ function writeH2 (client, request) {
     util.destroy(stream, err)
   })
 
-  stream.on('data', (chunk) => {
-    if (request.onData(chunk) === false) {
-      stream.pause()
-    }
-  })
-
   stream.once('close', () => {
     session[kOpenStreams] -= 1
     // TODO(HTTP/2): unref only if current streams count is 0