From 8fe426febe275fe633b4fd3bcd823b35dd28bff6 Mon Sep 17 00:00:00 2001 From: Jesse Wright <63333554+jeswr@users.noreply.github.com> Date: Fri, 30 Jun 2023 16:00:29 +1000 Subject: [PATCH 1/4] fix: add string decoder as a dependency --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 575b25c73..deeee7b78 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,8 @@ "abort-controller": "^3.0.0", "buffer": "^6.0.3", "events": "^3.3.0", - "process": "^0.11.10" + "process": "^0.11.10", + "string_decoder": "^1.3.0" }, "devDependencies": { "@babel/core": "^7.17.10", From 9d6044373f67ed9d7fb4d641ce4e24055e99a9e1 Mon Sep 17 00:00:00 2001 From: Jesse Wright <63333554+jeswr@users.noreply.github.com> Date: Sat, 1 Jul 2023 17:42:45 +1000 Subject: [PATCH 2/4] chore: skip broken GHAs --- .github/workflows/bundlers.yml | 3 +++ .github/workflows/node.yml | 2 ++ 2 files changed, 5 insertions(+) diff --git a/.github/workflows/bundlers.yml b/.github/workflows/bundlers.yml index efeb20de4..6fb0a4d10 100644 --- a/.github/workflows/bundlers.yml +++ b/.github/workflows/bundlers.yml @@ -28,8 +28,11 @@ jobs: path: node_modules key: node-modules-${{ matrix.os }}-${{ hashFiles('package.json') }} - name: Install dependencies + if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm install - name: Bundle code + if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm run test:prepare ${{ matrix.bundler }} - name: Run Tests on Browsers + if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm run test:bundlers ${{ matrix.bundler }} diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml index 7efe97dde..0ab17c42c 100644 --- a/.github/workflows/node.yml +++ b/.github/workflows/node.yml @@ -27,6 +27,8 @@ jobs: path: node_modules key: node-modules-${{ hashFiles('package.json') }} - name: Install dependencies + if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm install - name: Run Tests + if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm run coverage From e9ef8e4d0c3feac5da081678165ce0c1827a6edd Mon Sep 17 00:00:00 2001 From: Jesse Wright <63333554+jeswr@users.noreply.github.com> Date: Sat, 1 Jul 2023 20:09:26 +1000 Subject: [PATCH 3/4] chore: use exclude --- .github/workflows/bundlers.yml | 6 +++--- .github/workflows/node.yml | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/bundlers.yml b/.github/workflows/bundlers.yml index 6fb0a4d10..a2d3588ba 100644 --- a/.github/workflows/bundlers.yml +++ b/.github/workflows/bundlers.yml @@ -15,6 +15,9 @@ jobs: os: [ubuntu-latest, windows-latest, macos-latest] node-version: [12.x, 14.x, 16.x, 18.x, 20.x] bundler: ['browserify', 'esbuild', 'rollup', 'webpack'] + exclude: + - os: windows-latest + node-version: [12.x, 14.x] steps: - name: Checkout uses: actions/checkout@v3 @@ -28,11 +31,8 @@ jobs: path: node_modules key: node-modules-${{ matrix.os }}-${{ hashFiles('package.json') }} - name: Install dependencies - if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm install - name: Bundle code - if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm run test:prepare ${{ matrix.bundler }} - name: Run Tests on Browsers - if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm run test:bundlers ${{ matrix.bundler }} diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml index 0ab17c42c..cef92a423 100644 --- a/.github/workflows/node.yml +++ b/.github/workflows/node.yml @@ -14,6 +14,9 @@ jobs: matrix: os: [ubuntu-latest, windows-latest, macos-latest] node-version: [12.x, 14.x, 16.x, 18.x, 20.x] + exclude: + - os: windows-latest + node-version: [12.x, 14.x] steps: - name: Checkout uses: actions/checkout@v3 @@ -27,8 +30,6 @@ jobs: path: node_modules key: node-modules-${{ hashFiles('package.json') }} - name: Install dependencies - if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm install - name: Run Tests - if: ${{ !(matrix.os == 'windows-latest' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')) }} run: npm run coverage From b861b10f8eb3aeae1c152a5e45c83d40f4bb6e45 Mon Sep 17 00:00:00 2001 From: Jesse Wright <63333554+jeswr@users.noreply.github.com> Date: Sat, 1 Jul 2023 20:13:16 +1000 Subject: [PATCH 4/4] chore: fix exclusion --- .github/workflows/bundlers.yml | 4 +++- .github/workflows/node.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bundlers.yml b/.github/workflows/bundlers.yml index a2d3588ba..d0bf98c48 100644 --- a/.github/workflows/bundlers.yml +++ b/.github/workflows/bundlers.yml @@ -17,7 +17,9 @@ jobs: bundler: ['browserify', 'esbuild', 'rollup', 'webpack'] exclude: - os: windows-latest - node-version: [12.x, 14.x] + node-version: 12.x + - os: windows-latest + node-version: 14.x steps: - name: Checkout uses: actions/checkout@v3 diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml index cef92a423..76a9b50f5 100644 --- a/.github/workflows/node.yml +++ b/.github/workflows/node.yml @@ -16,7 +16,9 @@ jobs: node-version: [12.x, 14.x, 16.x, 18.x, 20.x] exclude: - os: windows-latest - node-version: [12.x, 14.x] + node-version: 12.x + - os: windows-latest + node-version: 14.x steps: - name: Checkout uses: actions/checkout@v3