Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.1 breaks ES5 compatibility #507

Closed
MonsieurLanza opened this issue Feb 27, 2023 · 6 comments
Closed

3.6.1 breaks ES5 compatibility #507

MonsieurLanza opened this issue Feb 27, 2023 · 6 comments

Comments

@MonsieurLanza
Copy link

MonsieurLanza commented Feb 27, 2023

Our ES5 build breaks when readable-stream gets updated to 3.6.1.

This commit precisely introduces ES6 syntax, such as const keywords, class methods shorthands…

fec7fe9

I am aware that ES5 is a somewhat old thing, however, in my understanding, an EcmaScript version bump should not occur in a patch version.

@kanongil
Copy link

Indeed. Either that or the support section needs an update…

v3.x.x of `readable-stream` is a cut from Node 10. This version supports Node 6, 8, and 10, as well as evergreen browsers, IE 11 and latest Safari. The breaking changes introduced by v3 are composed by the combined breaking changes in [Node v9](https://nodejs.org/en/blog/release/v9.0.0/) and [Node v10](https://nodejs.org/en/blog/release/v10.0.0/), as follows:

@mcollina
Copy link
Member

Sorry about this, it was definitely not the goal. Could you send me a small script to validate that I don't break it again?

@ningyougan
Copy link

hi,

you can use es-check to check your lib can be use by es5.

@mcollina
Copy link
Member

mcollina commented Mar 1, 2023

@ningyougan @kanongil @MonsieurLanza could you verify if #508 fixes it?

@ningyougan
Copy link

I change your new commit pkg in node_modules ,but oops

This dependency was not found:

* abort-controller in ./node_modules/browserify-sign/node_modules/readable-stream/lib/internal/streams/pipeline.js, ./node_modules/hash-base/node_modules/readable-stream/lib/internal/streams/pipeline.js

To install it, you can run: npm install --save abort-controller

I compare #508 with 3.6.1 ,it's a new external dep. Is aboort-controller necessary?

Thx for your congtribution! Maybe this bug is my bad, plz help me to confirm the question.

@mcollina
Copy link
Member

@ningyougan you would need to run this in an environment that has either a global AbortController or install abort-controller as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants