Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around the blog/index.md in the first year. #2564

Closed
wants to merge 1 commit into from
Closed

Work around the blog/index.md in the first year. #2564

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 9, 2019

This is quite hacky, but I don't know the root cause, so I couldn't think of a better way.

Regardless, this fixes the issue. I just point to the blog index page when year is 2011. Alternatively we could hide the older button completely, but the | separator makes it complex.

Requires #2563.

Fixes #2422.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 9, 2019

@phillipj: could this be a bug in metalsmith-yearly-pagination?

@phillipj
Copy link
Member

Good question!

I wouldn't be surprised if this was metalsmith-yearly-pagination' fault and plausibly should be fixed there. I'm more than happy to push a patch release if anyone finds the culprit in phillipj/metalsmith-yearly-pagination.

@XhmikosR
Copy link
Contributor Author

Unfortunately, I'm not very familiar with that codebase. :/

I'll make a PR with other tweaks there, though.

@XhmikosR
Copy link
Contributor Author

Alright, I made an upstream issue. Maybe @Trott could help us out there so that we don't have to use this workaround here.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 13, 2019

I changed the workaround to hide completely the link. I think it makes more sense and it's what I'd expect if we didn't hit this bug.

I'd still like to fix this upstream, but I had no luck so far there.

@XhmikosR XhmikosR marked this pull request as ready for review September 16, 2019 08:04
@XhmikosR XhmikosR mentioned this pull request Sep 16, 2019
@XhmikosR
Copy link
Contributor Author

Closing this since the issue should be fixed upstream and we'll get it sorted here with a dep update.

@XhmikosR XhmikosR closed this Sep 28, 2019
@XhmikosR XhmikosR deleted the master-xmr-blog-year-link branch September 28, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong path when there's no previous yearly archive
2 participants