Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary.js: use double quotes in the a tag. #2561

Merged
merged 1 commit into from
Sep 12, 2019
Merged

summary.js: use double quotes in the a tag. #2561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/helpers/summary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module.exports = (contents, locale, path) => {
.not((i, elem) => IGNORE_SELECTORS.some((selector) => $(elem).is(selector)))
.each((i, elem) => {
if (summary.length > SUMMARY_MAX_LENGTH) {
summary += `<p><a href='/${locale}/${path.replace(/\\/g, '/')}/'>Read more...</a></p>`
summary += `<p><a href="/${locale}/${path.replace(/\\/g, '/')}/">Read more...</a></p>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special reasons？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency. There's no other HTML attribute which uses single quotes AFAICT.

return false
}

Expand Down