Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary.js: use double quotes in the a tag. #2561

Merged
merged 1 commit into from
Sep 12, 2019
Merged

summary.js: use double quotes in the a tag. #2561

merged 1 commit into from
Sep 12, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 9, 2019

No functional change.

@@ -30,7 +30,7 @@ module.exports = (contents, locale, path) => {
.not((i, elem) => IGNORE_SELECTORS.some((selector) => $(elem).is(selector)))
.each((i, elem) => {
if (summary.length > SUMMARY_MAX_LENGTH) {
summary += `<p><a href='/${locale}/${path.replace(/\\/g, '/')}/'>Read more...</a></p>`
summary += `<p><a href="/${locale}/${path.replace(/\\/g, '/')}/">Read more...</a></p>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special reasons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency. There's no other HTML attribute which uses single quotes AFAICT.

@Trott Trott merged commit cdf1aa7 into nodejs:master Sep 12, 2019
@XhmikosR XhmikosR deleted the patch-2 branch September 12, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants