Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace i with em. #2522

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Replace i with em. #2522

merged 1 commit into from
Sep 7, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 7, 2019

Mostly for consistency and being more schematically correct.

Mostly for consistency and being more schematically correct.
Trott
Trott previously requested changes Sep 7, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I think i is more correct in most of these instances. Most of these are not about emphasis but about setting something apart or denoting it as a string that needs to be changed or "words as words".

@Trott Trott dismissed their stale review September 7, 2019 16:09

Actually, I'm not going to block this. I don't actually care that much, plus we probably want people to use the markdown equivalents anyway. This is especially totally fine with me if it's supposed to be a step towards eliminating the i, em, b, and strong HTML elements from our markdown entirely

@Trott Trott merged commit 901a245 into nodejs:master Sep 7, 2019
@XhmikosR XhmikosR deleted the master-xmr-em branch September 7, 2019 16:15
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 7, 2019

Yeah, the plan is to clean up the elements as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants