Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixture: change hbs rules to allow template class name formation without dashes and some typos #2481

Merged
merged 1 commit into from
Sep 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .htmllintrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"attr-quote-style": false,
"attr-req-value": false,
"id-class-style": "dash",
"id-class-ignore-regex": "{{.*?}}",
"img-req-alt": false,
"indent-style": "spaces",
"indent-width": 2,
Expand Down
2 changes: 1 addition & 1 deletion layouts/partials/footer.hbs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<a href="#" id="scroll-to-top">&uarr; <span>{{site.scrollToTop}}</span></a>

<footer{{#if className}} class="{{className}}"{{/if}}>
<footer {{#if className}} class="{{className}}"{{/if}}>

<div class="container">
<div class="linuxfoundation-footer">
Expand Down
2 changes: 1 addition & 1 deletion layouts/partials/header.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<nav>
<ul class="list-divider-pipe">
<li{{#equals path ''}} class="active"{{/equals}}>
<li {{#equals path ''}} class="active" {{/equals}}>
<a href="/{{site.locale}}/">{{site.home.text}}</a>
</li>

Expand Down
2 changes: 1 addition & 1 deletion layouts/partials/navigation.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{{#each nav}}
{{#equals @key ../key}}
{{#each this}}
<li{{#equals ../../path link}} class="active"{{/equals}}>
<li {{#equals ../../path link}} class="active" {{/equals}}>
{{#startswith link '/'}}
<a href="{{link}}">{{text}}{{#if subtext}} <span class="small color-lightgray">{{subtext}}</span>{{/if}}</a>
{{else}}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"load-schedule": "curl -sS https://raw.githubusercontent.com/nodejs/Release/master/schedule.json -o source/schedule.json",
"start": "npm run serve",
"test": "npm run test:lint && npm run test:unit && npm run test:smoke",
"test:lint": "standard --fix && htmllint **/*.hbs && stylint layouts/css && markdownlint \"**/*.md\" -i \"node_modules/\"",
"test:lint": "standard --fix && htmllint \"**/*.hbs\" && stylint layouts/css && markdownlint \"**/*.md\" -i \"node_modules/\"",
"test:unit": "tape tests/**/*.test.js | faucet",
"test:smoke": "tape tests/*.smoketest.js | faucet"
},
Expand Down