Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS LTS Linux download link dead #6360

Closed
theo-meow opened this issue Feb 28, 2024 · 18 comments · Fixed by #6485
Closed

NodeJS LTS Linux download link dead #6360

theo-meow opened this issue Feb 28, 2024 · 18 comments · Fixed by #6485
Labels

Comments

@theo-meow
Copy link

URL:

https://nodejs.org/

Browser Name:

Firefox

Browser Version:

123.0

Operating System:

Manjaro Linux 6.7.2

How to reproduce the issue:

  1. Using a Browser running under Linux, visit https://nodejs.org/en
  2. under "Download Node.js", click the left hand button that says "20.11.1 LTS"

Expected: tar.xz download
Actual: Dead link, reporting a 404 nginx error

Additional info:
It seems the link points to a x86 build, which does not exist.
Specifically, it points to:
https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-x86.tar.xz
While it should point to:
https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-x64.tar.xz

@theo-meow theo-meow added the bug label Feb 28, 2024
@theo-meow
Copy link
Author

nodejs

for reference

@theo-meow
Copy link
Author

theo-meow commented Mar 1, 2024

I believe this is due to bitness detection in util/getNodeDownloadUrl.ts
For whatever reason it detects an x86 build, even though I am on x64.
In Issue nodejs/build#885, 32bit builds were dropped.
My suggestion, though this is a dirty solution, would be to always link x64 builds for linux, since any other bitness can never be delivered.

@ovflowd
Copy link
Member

ovflowd commented Mar 2, 2024

I believe this is due to bitness detection in util/getNodeDownloadUrl.ts For whatever reason it detects an x86 build, even though I am on x64. In Issue nodejs/build#885, 32bit builds were dropped. My suggestion, though this is a dirty solution, would be to always link x64 builds for linux, since any other bitness can never be delivered.

This issue only exists on the old/legacy Node.js website. Can you check if the same issue happens on the new website? (https://beta-node-js-org.vercel.app/en) (This website is not yet public)

@theo-meow
Copy link
Author

Hi @ovflowd , I have tried this and the issue does persist.
This does not seem solved on the new site.

@ovflowd
Copy link
Member

ovflowd commented Mar 2, 2024

Hi @ovflowd , I have tried this and the issue does persist. This does not seem solved on the new site.

We use the Browser Bitness API to get your system bitness. What browser do you use? You wrote 123.0 on Browser, is that a version or?

Note that it is only supported on these Browsers: https://developer.mozilla.org/en-US/docs/Web/API/NavigatorUAData/getHighEntropyValues

@theo-meow
Copy link
Author

theo-meow commented Mar 2, 2024

As written in my initial message, my browser is Firefox 123.0 (version).
On other websites that I tried, my browser bitness comes back as 32 bit too.

Whatever the case may be; I think since there are no x86 versions of nodejs for linux available, the website should not generate a download link that can never be valid.

@ovflowd
Copy link
Member

ovflowd commented Mar 3, 2024

As written in my initial message, my browser is Firefox 123.0 (version).

I completely missed the name of the Browser!

And yes, this API is not available on Firefox.

Whatever the case may be; I think since there are no x64 versions of nodejs for linux available, the website should not generate a download link that can never be valid.

I'm unfortunately unable to reproduce your issue on the redesign. Could you mention in which tab you're facing this issue? The only tab supporting Linux on the redesign is the "Prebuilt Binaries" one, and we don't even show a x86 option for Linux there 🤔 could you record a screenshot/video of the issue on the redesig? i.e. https://beta-node-js-org.vercel.app

@theo-meow
Copy link
Author

In the prebuilt binaries I do not have this issue,
However on the home page it looks like the page autodetects a linux x86, and generates a corresponding download link.
I have reproduced this on 3 different devices, all running the latest KDE manjaro linux. So it's probably not something weird with my setup that's causing this.

Find a GIF attached.

nodejs

@ovflowd
Copy link
Member

ovflowd commented Mar 3, 2024

In the prebuilt binaries I do not have this issue,

However on the home page it looks like the page autodetects a linux x86, and generates a corresponding download link.

I have reproduced this on 3 different devices, all running the latest KDE manjaro linux. So it's probably not something weird with my setup that's causing this.

Find a GIF attached.

nodejs

Right, but again, just to clarify the issue is not that it is detecting x86, it is just probably fall-backing to x86... But Ill work on a fix anyways

@o5k
Copy link

o5k commented Mar 19, 2024

by the by https://nodejs.org/en/download/prebuilt-binaries links to https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-64.tar.xz (note the 64 instead of x64)... which is also a 404. to bypass it you need to click to a different option then back (at which point it will select x64 properly)

image

Tested on FF 115 (Waterfox G6.0.9, which is built against FF ESR). Please respect the UNOFFICIAL DRAFT splashed all over https://wicg.github.io/ua-client-hints/#dom-navigatoruadata-gethighentropyvalues ...

@ovflowd
Copy link
Member

ovflowd commented Mar 19, 2024

Screenshot Why the hell is this broken for 3 weeks (and counting)? FF has a 7.26% desktop browser market share

This issue has nothing to do with Firefox. It affects Firefox, but it's not related to Firefox.

@ovflowd
Copy link
Member

ovflowd commented Mar 19, 2024

by the by nodejs.org/en/download/prebuilt-binaries links to https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-64.tar.xz (note the 64 instead of x64)... which is also a 404. to bypass it you need to click to a different option then back (at which point it will select x64 properly)

Oh that seems a typo from our side. @nodejs/nodejs-website can someone look into this?

@ovflowd
Copy link
Member

ovflowd commented Mar 19, 2024

Screenshot Why the hell is this broken for 3 weeks (and counting)? FF has a 7.26% desktop browser market share

We did fix this issue, or at least we thought so that we did with the recently released redesign. Please mind your tone. We are all volunteers here.

@anandMohanan
Copy link

image

Using firefox version 123.0.1 and the issue still exists FYI.
image

image

@ovflowd
Copy link
Member

ovflowd commented Mar 19, 2024

Please mind your tone.

no fix your software

As mentioned before, we are working on a fix already, so there's no need for hostility.

@ovflowd
Copy link
Member

ovflowd commented Mar 19, 2024

I'd appreciate it if y'all could test https://nodejs-org-git-fork-canerakdas-fix-linux-bitness-openjs.vercel.app/ this preview branch and check if the bug is fixed.

@anandMohanan
Copy link

Hi @ovflowd
image
image

Yes, I am able to download the file now using this branch https://nodejs-org-git-fork-canerakdas-fix-linux-bitness-openjs.vercel.app/
Have a Great day.

@theo-meow
Copy link
Author

I'd appreciate it if y'all could test https://nodejs-org-git-fork-canerakdas-fix-linux-bitness-openjs.vercel.app/ this preview branch and check if the bug is fixed.

Looks good to me, unable to reproduce the bug on this website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants