Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock translation process #2906

Closed
alexandrtovmach opened this issue Jan 22, 2020 · 17 comments
Closed

Unblock translation process #2906

alexandrtovmach opened this issue Jan 22, 2020 · 17 comments

Comments

@alexandrtovmach
Copy link
Contributor

@nodejs/website @nodejs/i18n
We need to unblock translation process here nodejs/i18n#72. For that I need github personal access token generated under nodejs organization with next scopes:
image

Token will be used here:
image

Please help me with that

@Trott
Copy link
Member

Trott commented Feb 15, 2020

@nodejs/i18n: Should this be added to the @nodejs/tsc agenda so we can get this resolved one way or the other? Or is there still some work and/or data-gathering that needs to happen?

@bnb
Copy link
Contributor

bnb commented Feb 17, 2020

@Trott is the TSC the proper body to decide this? i18n is technically a CommComm initiative. Not sure if there’s historical blocking of this from the TSC.

My assumption would be requests like this would be an admin issue. Is that accurate?

@jasnell
Copy link
Member

jasnell commented Feb 17, 2020

i18n was transitioned to commcomm but if commcomm isn't making progress with it, it could be transitioned back

@obensource
Copy link
Member

@Trott @bnb @jasnell we just started picking up progress again this past week (had a WG meeting on Friday), and have generated action items including this. We need to repeat similar steps to this in order to set this up. I took this as an action item this week, since we're planning on picking up the pace and meeting weekly.

👉 Here's the recap.

@bnb
Copy link
Contributor

bnb commented Feb 17, 2020

i18n was transitioned to commcomm but if commcomm isn't making progress with it, it could be transitioned back

If there are folks who are willing to work on it, it shouldn’t matter where it lives - not sure how progress is associated with CommComm or TSC ownership. I would hope such a line in the sand does not exist ❤️

@obensource
Copy link
Member

@bnb same here. Also i18n itself isn't so cut and dry already. There is diversity in the WG that spans between both TSC-oriented and CommComm-oriented work (which we reassessed and reasserted at length during our last meeting), and it is niche enough that it's within the best interest of the WG to maintain that diversity to mutually support each end (akin to a relationship between delegates and invited experts).

The work that @srl295 is doing to support Globalization in the runtime, alongside the work that @zeke, @RichardLitt, myself and others have done to set up translation infrastructure is all good – I believe the hangup has been that I and the working group haven't done enough to foster reciprocity for maintainers so bottlenecks like this don't happen (as well as new contributors, and translators). That work is pretty much top priority on the agenda from our last meeting, and it really doesn't matter where the help comes from, or which top level committee contributors represent. We just want to see the hangups alleviated and progress made on an effort with so much potential to make node more accessible to an increasingly larger global audience. 👍

@Trott
Copy link
Member

Trott commented Feb 18, 2020

@bnb I suggested TSC because that's where integration requests usually get held up based on security concerns etc. But yes, the admin repo would be a fine place to take it instead. Maybe even add labels to get it on both TSC and CommComm agendas if necessary.

@obensource
Copy link
Member

@Trott @bnb @jasnell apologies if I misread the context of this thread (re my last/long-winded comment).

@jasnell
Copy link
Member

jasnell commented Feb 18, 2020

I was just responding to whether things could be taken back to the tsc if necessary :) As the one who initially proposed moving i18n under commcomm I'm more than happy to see it thrive there!

@zeke
Copy link
Contributor

zeke commented Mar 10, 2020

Hey @alexandrtovmach I finally managed to get my PGP setup working again (gory details at https://github.com/nodejs-private/secrets/pull/87#issuecomment-597173069) and I now have access to the @nodejs-crowdin GitHub user again, so I can generate a new personal access token to re-enable the Crowdin integration.

I see two projects when I log into Crowdin using GitHub SSO as @nodejs-crowdin:

Can you remind me which of these projects needs a new token?

Here's a link I can use to generate the token, once I know which project to apply it to: https://github.com/settings/tokens/new?scopes=repo,user,admin:repo_hook&description=Crowdin%20integration

@nschonni
Copy link
Member

I believe it should be nodejs-website. The regular nodejs should be the existing API docs from nodejs/node.
It looks like the API docs also got pushed to nodejs-website, which isn't correct.

@zeke
Copy link
Contributor

zeke commented Mar 13, 2020

Added a new token! Details here: nodejs/i18n#223 (comment)

@zeke zeke closed this as completed Mar 13, 2020
@nschonni
Copy link
Member

Re-opening since that isn't the right project, and the content that the node-website is still pointing to the API docs, not this repo

@nschonni nschonni reopened this Mar 13, 2020
@RichardLitt
Copy link

@nschonni Thanks for being on top of this! Apologies.

@zeke
Copy link
Contributor

zeke commented Mar 13, 2020

Thanks for pointing that out. Fixed in nodejs/i18n#72 (comment)

@zeke zeke closed this as completed Mar 13, 2020
@alexandrtovmach
Copy link
Contributor Author

@zeke Thanks for amazing news and sorry for delay

@alexandrtovmach
Copy link
Contributor Author

BTW: I haven't access to https://github.com/nodejs-private/secrets/pull/87#issuecomment-597173069, probably you can write guide somewhere else? Gist, wiki?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants