Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch lang-picker-toggler to a button #2545

Closed
XhmikosR opened this issue Sep 8, 2019 · 5 comments · Fixed by #2566
Closed

Switch lang-picker-toggler to a button #2545

XhmikosR opened this issue Sep 8, 2019 · 5 comments · Fixed by #2566

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 8, 2019

Should be better for accessibility and we will probably simplify a few things.

I'll take a stab at it in the next days.

@moshfeu
Copy link

moshfeu commented Sep 10, 2019

If you already touch it, it will be better to add more accessibility aspects to the list (options also should be focusable, aria-expanded, aria-haspopup etc.)

@XhmikosR
Copy link
Contributor Author

See #2566

Only toggling aria-expanded is left.

@moshfeu
Copy link

moshfeu commented Sep 10, 2019

🔥
I'm not familiar with that syntax but I can't see how the options will be focusable (navigate via tabs, or even arrows)

@XhmikosR
Copy link
Contributor Author

That doesn't work, unfortunately. Nor the toggler closes with the Esc key. But you are more than welcome to help me out in that PR :)

@moshfeu
Copy link

moshfeu commented Sep 10, 2019

Ok.
I'll see what I can do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants