-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
htmllint issues on Windows #2459
Comments
https://travis-ci.org/XhmikosR/nodejs.org/jobs/576205825 If Windows on Travis CI wasn't so slow, I'd say we added it, but it's too slow. Are there any plans to switch to GitHub Actions CI? |
@XhmikosR , It seems this is also checked in CI, just like what you said in https://travis-ci.org/XhmikosR/nodejs.org/jobs/576205825, and I've fixed it in my submit ;) BTW: Do you mean the time in windows or Linux is a huge difference when using Htmllint? I'd say that we should keep it because a pretty code needs time to be checked with. As for GitHub Action CI, this may be done in the future. Until now we have to use Htmllint instead. |
@MaledongGit: yeah I meant Windows, but Travis is a no go for this currently, unfortunately. About your PR, I commented there. These aren't real issues, and for example, it hasn't warned us for indentation issues. We shouldn't be using htmllint IMO. |
@XhmikosR:You mean in Linux it skipped the check……?This is really strange.... |
I'd say it's a bug in htmllint probably, that behaves differently on Windows hence the errors. |
Closing since this no longer occurs. |
It seems httmllint gets confused by the missing space in the handlebar templates, but this issue only appears on Windows hence why Travis CI builds just pass.
I don't think we should change the code to add the space back. In fact I'm not sure if htmllint offers any value... The website was full of serious HTML validation errors that were caught by the official HTML validator which I plan to add here eventually.
Let me know how to proceed.
The text was updated successfully, but these errors were encountered: