test: improve test for crypto pbkdf2 #9883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use assert.strictEqual instead of assert.equal - add regexp for assert.throws
cjihrig
approved these changes
Dec 1, 2016
imyller
added
crypto
lpinca
reviewed
Dec 2, 2016
| } | ||
|
|
||
| // Error path should not leak memory (check with valgrind). | ||
| assert.throws(function() { | ||
| crypto.pbkdf2('password', 'salt', 1, 20, null); | ||
| }); | ||
| }, /No callback/); |
There was a problem hiding this comment.
Nit: can you please add the full error message and add ^ and $ at the beginning and end of the regex?
There was a problem hiding this comment.
Sure, I have updated other error messages too
lpinca
approved these changes
Dec 2, 2016
Test for full error message with `^` and `$`
joyeecheung
force-pushed
the
master
branch
2 times, most recently
from
fd96d6a
to
71ba2df
Compare
joyeecheung
commented
Dec 2, 2016
| } | ||
|
|
||
| // Error path should not leak memory (check with valgrind). | ||
| assert.throws(function() { | ||
| crypto.pbkdf2('password', 'salt', 1, 20, null); | ||
| }); | ||
| }, /No callback/); |
There was a problem hiding this comment.
Sure, I have updated other error messages too
jasnell
approved these changes
Dec 3, 2016
|
CI failures are build failures and unrelated to this change. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 3, 2016
- use assert.strictEqual instead of assert.equal - add regexp for assert.throws PR-URL: nodejs#9883 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in aeec621. Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
- use assert.strictEqual instead of assert.equal - add regexp for assert.throws PR-URL: #9883 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
- use assert.strictEqual instead of assert.equal - add regexp for assert.throws PR-URL: nodejs#9883 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
- use assert.strictEqual instead of assert.equal - add regexp for assert.throws PR-URL: nodejs#9883 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- use assert.strictEqual instead of assert.equal - add regexp for assert.throws PR-URL: #9883 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change