Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove Sam Roberts from release team #9862

Closed
wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Also, remove my key, since I never did a release.

/to @mhdawson @Fishrock123 @jasnell

Also, remove my key, since I never did a release.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 30, 2016
@MylesBorins
Copy link
Contributor

@sam-github before this lands I want to confirm, do you 100% have no interest in helping with releases in the future?

@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

I'm going to go ahead and land. If @sam-github does change his mind we can get him readded.

jasnell pushed a commit that referenced this pull request Dec 5, 2016
Also, remove my key, since I never did a release.

PR-URL: #9862
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Landed in 3b9749e.

@jasnell jasnell closed this Dec 5, 2016
@sam-github
Copy link
Contributor Author

@thealphanerd The future is a faraway country. I've lots of interests, and little time, I doubt I'll have time in the next half year to need to sign releases, and if I do, we can add my keys back in.

Note that I have not signed any releases in the past.

@sam-github sam-github deleted the remove-sam-release-key branch December 6, 2016 17:57
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
Also, remove my key, since I never did a release.

PR-URL: #9862
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Also, remove my key, since I never did a release.

PR-URL: nodejs#9862
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
Also, remove my key, since I never did a release.

PR-URL: #9862
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
Also, remove my key, since I never did a release.

PR-URL: #9862
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Also, remove my key, since I never did a release.

PR-URL: #9862
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Also, remove my key, since I never did a release.

PR-URL: #9862
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants