test: refactor test-fs-non-number-arguments-throw #9844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback.
targos
added
fs
cjihrig
reviewed
Dec 1, 2016
|
|
||
| assert.throws(function() { | ||
| fs.createReadStream(tempFile, { start: 4, end: '6' }); | ||
| }, "end as string didn't throw an error"); | ||
| }, /^TypeError: "end" option must be a Number$/, | ||
| "end as string didn't throw an error"); |
There was a problem hiding this comment.
Could you add "for createReadStream" to the error message for consistency.
cjihrig
approved these changes
Dec 1, 2016
lpinca
approved these changes
Dec 1, 2016
targos
added a commit
to targos/node
that referenced
this pull request
Dec 2, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: nodejs#9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in de495c0 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: #9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: nodejs#9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: nodejs#9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
This test is failing on v4.x. Is this expected behavior? |
targos
added a commit
to targos/node
that referenced
this pull request
Dec 21, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: nodejs#9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
2 tasks
|
Backport PR: #10383 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: #9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: #9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: #9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: #9844 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, fs
Description of change
CI: https://ci.nodejs.org/job/node-test-pull-request/5024/