doc: clarify slashes-appending in url module #9731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
doc
nodejs-github-bot
added
doc
lpinca
reviewed
Nov 22, 2016
| * `urlObject.slashes` property is true; | ||
| * `urlObject.protocol` begins with `http`, `https`, `ftp`, `gopher`, or | ||
| `file`; | ||
| * `urlObject.protocol` is `undefined`. |
There was a problem hiding this comment.
Is this correct?
> url.format({ hostname: 'example.com' })
'example.com'
There was a problem hiding this comment.
It appears not. I'll update it.
lpinca
approved these changes
Nov 23, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 24, 2016
PR-URL: nodejs#9731 Ref: nodejs#9521 Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in c1133f4 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
PR-URL: #9731 Ref: #9521 Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9731 Ref: #9521 Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9731 Ref: #9521 Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc url
Description of change
Refs: #9521