doc: changed order of invocations in example. #9614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.
nodejs-github-bot
added
doc
|
I'm not getting an error prior to this change. |
|
Not getting an error either. That said, I prefer this ordering. |
|
Yea, I do prefer this order too. |
lpinca
approved these changes
Nov 19, 2016
cjihrig
reviewed
Nov 20, 2016
|
|
||
| req.on('error', (e) => { | ||
| console.error(e); | ||
| }); | ||
| req.end(); | ||
|
|
There was a problem hiding this comment.
No need for this blank line.
cjihrig
approved these changes
Nov 20, 2016
italoacasas
pushed a commit
that referenced
this pull request
Nov 24, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 550a958 Thanks for the contribution @atrioom |
|
@italoacasas the landed commit does not follow the commit message guidelines. |
italoacasas
pushed a commit
that referenced
this pull request
Nov 24, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
@lpinca I made some changes, I hope that one fit better. |
|
@italoacasas not a biggie but the second line ("When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.") is too long. Those lines should be wrapped at 72 chars. |
|
Hello and thank you for the help. I had this issue in a full grown application, I will try to reproduce it in a small test environment. Maybe add modules until I get the error. Thanks for accepting it anyways. |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.