-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix the index order in pseudocode of modules #9562
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
module
Issues and PRs related to the module subsystem.
labels
Nov 12, 2016
shigeki
approved these changes
Nov 12, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM, but you need to check |
silverwind
approved these changes
Nov 12, 2016
fix the index order in pseudocode of modules.
shigeki
pushed a commit
that referenced
this pull request
Nov 12, 2016
fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
This is a trivial change so I landed it right now in f673c97. |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
Description of change
fix the index order in pseudocode of modules.