Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-zlib.js #9544

Closed
wants to merge 2 commits into from
Closed

test: refactor test-zlib.js #9544

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 10, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test zlib

Description of change
  • minor layout changes for clarity
  • assert.equal() and assert.ok() swapped out for assert.strictEqual()
  • var -> const for modules included via require()

@Trott Trott added test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem. labels Nov 10, 2016
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 10, 2016
evanlucas
evanlucas approved these changes Nov 11, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 suggestions (feel free to ignore them)

test/parallel/test-zlib.js
@@ -36,7 +37,7 @@ if (!process.env.PUMMEL) {
strategy = [0];
}

var fs = require('fs');
const fs = require('fs');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move these to the top of the file?

test/parallel/test-zlib.js
testFiles.forEach(function(file) {
tests[file] = fs.readFileSync(path.resolve(common.fixturesDir, file));
});

var util = require('util');
var stream = require('stream');
const util = require('util');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move these as well?

mhdawson
mhdawson approved these changes Nov 11, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
test: refactor test-zlib.js
acecd18 
* minor layout changes for clarity
* assert.equal() and assert.ok() swapped out for assert.strictEqual()
* var -> const for modules included via require()
@Trott
squash: nit
afb904f
@Trott
Copy link
Member Author

Trott commented Nov 12, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4831/

@Trott
Copy link
Member Author

Trott commented Nov 13, 2016

Failing CI is build failure (just fixed by jbergstroem a few minutes ago) unrelated to this change. Everything else looks ✅. Landing!

Trott added a commit to Trott/io.js that referenced this pull request Nov 13, 2016
@Trott
test: refactor test-zlib.js
fc44bd4 
* minor layout changes for clarity
* assert.equal() and assert.ok() swapped out for assert.strictEqual()
* var -> const for modules included via require()

PR-URL: nodejs#9544
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 13, 2016

Landed in fc44bd4

@Trott Trott closed this Nov 13, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@Trott @addaleax
test: refactor test-zlib.js
f3db5e4 
* minor layout changes for clarity
* assert.equal() and assert.ok() swapped out for assert.strictEqual()
* var -> const for modules included via require()

PR-URL: #9544
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@Trott @addaleax
test: refactor test-zlib.js
7bd9ecd 
* minor layout changes for clarity
* assert.equal() and assert.ok() swapped out for assert.strictEqual()
* var -> const for modules included via require()

PR-URL: nodejs#9544
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Trott @MylesBorins
test: refactor test-zlib.js
cc98aa3 
* minor layout changes for clarity
* assert.equal() and assert.ok() swapped out for assert.strictEqual()
* var -> const for modules included via require()

PR-URL: #9544
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
@Trott Trott deleted the zlib-refactor branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @evanlucas @lpinca @cjihrig @mhdawson @MylesBorins @addaleax @nodejs-github-bot