test: add test for broken child process stdio #9528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
reviewed
Nov 9, 2016
| const ChildProcess = require('internal/child_process').ChildProcess; | ||
| const original = ChildProcess.prototype.spawn; | ||
|
|
||
| ChildProcess.prototype.spawn = function () { |
There was a problem hiding this comment.
I'm seeing a jslint error on this line:
18:40 error Unexpected space before function parentheses space-before-function-paren
danbev
approved these changes
Nov 9, 2016
|
@danbev sorry. Fixed. |
mscdex
added
the
child_process
Trott
approved these changes
Nov 10, 2016
| const cp = require('child_process'); | ||
|
|
||
| if (process.argv[2] === 'child') { | ||
| setTimeout(() => {}, common.platformTimeout(1000)); |
There was a problem hiding this comment.
The test works reliably for me (and runs faster) with the setTimeout() replaced with a setImmediate(). Are we sure that the timer is needed here? If so, any chance we can bring it down to 100ms instead of 1000ms?
There was a problem hiding this comment.
A setImmediate() is likely a safe. I just wanted to make sure that the spawned process didn't complete before the 1ms timeout in the third scenario.
mhdawson
approved these changes
Nov 10, 2016
|
CI to validate across platforms: https://ci.nodejs.org/job/node-test-pull-request/4819/ |
|
CI again without the |
|
The latest CI run failed on AIX due to the child process exiting too quickly, and hence not being killed. Adding the timeout back, and setting the delay to 100, as requested in #9528 (comment). |
This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created. PR-URL: nodejs#9528 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Nov 22, 2016
This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created. PR-URL: #9528 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created. PR-URL: nodejs#9528 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created. PR-URL: #9528 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created. PR-URL: #9528 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created. PR-URL: #9528 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created.
If you look at child process coverage, this adds coverage for the
elseconditions on lines 224, 227, 234, 237, 256, and 275.