src: speed up module loading #9132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
c++
nodejs-github-bot
added
the
c++
|
FreeBSD fails looks unrelated. |
|
Out of curiosity, how much of a speed up is this? |
|
Nothing spectacular, it's on the order of 50-100 us per file on my system. |
|
(the pending status of |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999
to
83c7a88
Compare
|
One more CI run because the previous one had infrastructure issues: https://ci.nodejs.org/job/node-test-pull-request/4648/ |
Stop reading from disk when we read fewer bytes than requested because the next read will be the zero-sized EOF. PR-URL: nodejs#9132 Reviewed-By: James M Snell <[email protected]>
Don't bother shrinking the read buffer on the final read because we dispose it immediately afterwards. Avoids some unnecessary memory allocation and copying. PR-URL: nodejs#9132 Reviewed-By: James M Snell <[email protected]>
bnoordhuis
force-pushed
the
speed-up-module-loading
branch
from
cfcc70f
to
d52f5dc
Compare
evanlucas
pushed a commit
that referenced
this pull request
Nov 2, 2016
Stop reading from disk when we read fewer bytes than requested because the next read will be the zero-sized EOF. PR-URL: #9132 Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Nov 2, 2016
Don't bother shrinking the read buffer on the final read because we dispose it immediately afterwards. Avoids some unnecessary memory allocation and copying. PR-URL: #9132 Reviewed-By: James M Snell <[email protected]>
|
hey @bnoordhuis should this be backported? Assuming it needs more time to bake either way |
|
It could be back-ported but it doesn't need to be, it's not a bug fix. |
MylesBorins
added
the
baking-for-lts
MylesBorins
added
dont-land-on-v6.x
and removed
baking-for-lts
|
setting don't land on this for v6.x for now. Please feel free to let me know if you think we should re consider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/4540/