test: minor replace var by const #8621
Conversation
scips
force-pushed
the
improve-test-tls-zero-clear-in
branch
from
0336cb9
to
308d155
Compare
|
@cjihrig changed to test: replace var by const test-tls-zero-clear-in |
|
CI failures with arm-fanned are unrelated. |
|
I thought we were against these sort of changes and that they were churn unless they introduce changes that are not changes from |
|
@benjamingr This is related to nodejs/code-and-learn#56 (comment) I'll start the process of landing this. |
PR-URL: #8621 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Although I don’t have any strong feelings about this: Yes, that was more or less my impression, too. I think the problematic effects are definitely smaller for test files, and overall I’m sorry for not being prepared for the number of attendees and falling back to a more ad-hoc way of distributing first contributions that may have led to some unclarity as to what would be considered a proper change and what not. I do think the value of having gained quite a few people who are now familiar with the contribution process is non-negligible, though.
I’m not sure if @benjamingr’s comment was meant as an objection, but if so, maybe landing this was a bit premature? |
Good point @addaleax. I personally didn't read his comment as an objection to this specific PR (in wider context of other code+learn PRs), but definitely try be more sensitive when evaluating feedbacks in other PRs. Thank you. I've taken up the task of landing these code+learn session contributions and I've tried to be bit more forgiving to new contributors about minor details (commit title wording) and fix those in the landing process. Hopefully thats ok? |
Imho, that is not only ok, that is awesome. 👍 |
PR-URL: #8621 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change